lkml.org 
[lkml]   [2023]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 07/14] KVM: s390: selftest: memop: Fix integer literal
    Date
    The address is a 64 bit value, specifying a 32 bit value can crash the
    guest. In this case things worked out with -O2 but not -O0.

    Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Fixes: 1bb873495a9e ("KVM: s390: selftests: Add more copy memop tests")
    ---
    tools/testing/selftests/kvm/s390x/memop.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c
    index 3ec501881c7c..55b856c4d656 100644
    --- a/tools/testing/selftests/kvm/s390x/memop.c
    +++ b/tools/testing/selftests/kvm/s390x/memop.c
    @@ -514,7 +514,7 @@ static void guest_copy_key_fetch_prot_override(void)
    GUEST_SYNC(STAGE_INITED);
    set_storage_key_range(0, PAGE_SIZE, 0x18);
    set_storage_key_range((void *)last_page_addr, PAGE_SIZE, 0x0);
    - asm volatile ("sske %[key],%[addr]\n" :: [addr] "r"(0), [key] "r"(0x18) : "cc");
    + asm volatile ("sske %[key],%[addr]\n" :: [addr] "r"(0L), [key] "r"(0x18) : "cc");
    GUEST_SYNC(STAGE_SKEYS_SET);

    for (;;) {
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-03-26 23:56    [W:2.914 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site