Messages in this thread | | | Date | Tue, 24 Jan 2023 16:17:49 +0100 | Subject | Re: [PATCH linux-next v4 4/4] dt-bindings: usb: Fix device tree binding for VL817 hub controller | From | Krzysztof Kozlowski <> |
| |
On 24/01/2023 15:40, Anand Moon wrote: > Cleanup by removing unneeded quotes from refs and > add maxItems to reset-gpios and fix the required list. > > Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller") > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I think it's the first time I see this patch. Where did I review it?
Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching).
Subject: drop second/last, redundant "device tree binding for". The "dt-bindings" prefix is already stating that these are bindings.
> Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > .../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml > index 5f9771e22058..23a13e1d5c7a 100644 > --- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml > +++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
Best regards, Krzysztof
| |