Messages in this thread | | | Date | Tue, 24 Jan 2023 09:09:32 -0600 | From | David Vernet <> | Subject | Re: [PATCH bpf-next 3/3] bpf/selftests: Verify struct_ops prog sleepable behavior |
| |
On Mon, Jan 23, 2023 at 09:32:03PM -0800, Alexei Starovoitov wrote: > On Mon, Jan 23, 2023 at 3:22 PM David Vernet <void@manifault.com> wrote: > > > > +static struct dummy_st_ops *open_load_skel(void) > > +{ > > + int err; > > + struct dummy_st_ops *skel; > > + > > + skel = dummy_st_ops__open(); > > + if (!ASSERT_OK_PTR(skel, "dummy_st_ops_open")) > > + return NULL; > > + > > + err = bpf_program__set_flags(skel->progs.test_3, BPF_F_SLEEPABLE); > > Feels that this is incomplete without libbpf support. > Instead of: > +SEC("struct_ops/test_3") > the users should be able to: > +SEC("struct_ops.s/test_3") > > and the above manual set_flags won't be needed.
Thanks for the pointer, agreed that's far better (and matches existing behavior for other prog types). Will address this in v2.
| |