Messages in this thread | | | Date | Tue, 24 Jan 2023 10:14:44 -0400 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down |
| |
On Tue, Jan 24, 2023 at 02:11:50PM +0000, David Howells wrote: > Jason Gunthorpe <jgg@nvidia.com> wrote: > > > if (cleanup_flags & PAGE_CLEANUP_UNPIN) > > gup_put_folio(folio, 1, true); > > else if (cleanup_flags & PAGE_CLEANUP_PUT) > > gup_put_folio(folio, 1, false); > > gup_put_folio() doesn't take a bool - it takes FOLL_PIN and FOLL_GET:
My point was to change that to take a 'bool unpin' because FOLL_PIN is not to be used outside gup.c
Jason
| |