Messages in this thread | | | From | <> | Subject | Re: [PATCH 06/15] soc: add Ambarella driver | Date | Tue, 24 Jan 2023 08:46:41 +0000 |
| |
Hey,
>>> +++ b/drivers/soc/ambarella/Makefile >>> @@ -0,0 +1,3 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only >>> + >>> +obj-$(CONFIG_ARCH_AMBARELLA) += soc.o >> >> The subdirectory is already gated by this symbol, so is there much point >> gating it on the same one again? > > Yeah, it lookgs kind of redundant now, but I will upstream other drivers after > this series get merged, which are not gated by this symbol.
You could make the directory by obj-y, and therefore always included, and have various drivers controlled by their own Kconfig symbols.
Or else, you could leave the directory controlled by ARCH_AMBARELLA and make the above `obj-y += soc.o` instead, since it's always going to be built if the directory is included.
Thanks, Conor.
| |