lkml.org 
[lkml]   [2023]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 0/5] iio: adc: qcom-spmi-vadc: Propagate fw node label to userspace
On 2023-01-22 16:59:47, Jonathan Cameron wrote:
> On Mon, 16 Jan 2023 23:09:04 +0100
> Marijn Suijten <marijn.suijten@somainline.org> wrote:
>
> > Implement read_label in qcom-spmi-vadc to see DT-specified label names
> > in userspace. At the same time clear up some documentation around
> > extend_name to promote read_label, and normalize similar code in
> > qcom-spmi-adc5.
> >
>
> I think this is a good route forwards, but it is making changes
> to ABI so I definitely want input on this from at least one of
> the qualcomm maintainers before I pick it up - particularly
> the changes in patch 3.
>
> Don't want to cause anyone nasty surprises.

Ack, patch 3 is the odd one of the bunch (as discussed many times
prior). It is an ABI break and would effectively obsolete "iio: adc:
qcom-spmi-adc5: Fix the channel name" [1] as it then only affects a few
dev_err/dev_dbg. Let's wait and hear from Qcom maintainers.

[1]: https://lore.kernel.org/linux-arm-msm/20230118100623.42255-1-andriy.shevchenko@linux.intel.com/

- Marijn

\
 
 \ /
  Last update: 2023-03-26 23:51    [W:0.063 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site