Messages in this thread | | | Date | Fri, 20 Jan 2023 11:05:23 -0500 | From | Brian Masney <> | Subject | Re: [PATCH v3 2/2] selftests: add tests for prctl(SET_HIDE_SELF_EXE) |
| |
On Fri, Jan 20, 2023 at 11:25:12AM +0100, Giuseppe Scrivano wrote: > Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
The other patch looks reasonable to me. I'm not familiar with this part of the kernel so I'm not going to leave a R-b tag on it.
> --- /dev/null > +++ b/tools/testing/selftests/prctl/hide-self-exe.c > @@ -0,0 +1,114 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Tests for prctl(PR_GET_HIDE_SELF_EXE, ...) / prctl(PR_SET_HIDE_SELF_EXE, ...) > + * > + */ > + > +#include <stdio.h> > +#include <stdlib.h> > +#include <unistd.h> > +#include <signal.h> > +#include <inttypes.h> > +#include <errno.h> > +#include <fcntl.h> > +#include <sys/wait.h> > + > +#include <sys/prctl.h> > +#include <linux/prctl.h>
Just a minor nit if you need to post a v4: Sort the includes by name.
Brian
| |