Messages in this thread | | | Date | Thu, 19 Jan 2023 16:26:51 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH V3 2/2] usb: gadget: u_ether: Don't warn in gether_setup_name_default() |
| |
On Thu, Jan 19, 2023 at 01:38:15PM +0000, Jon Hunter wrote: > > On 19/01/2023 10:46, Greg Kroah-Hartman wrote: > > ... > > > In looking at this further, you are right, the structures are not > > initialized properly yet. > > > > So move these to a different function entirely, they should be in > > gether_register_netdev() instead, after the device is registered with > > the system. > > > I wonder if this is even necessary. Looking at gether_register_netdev() it > already has ... > > status = register_netdev(net); > if (status < 0) { > dev_dbg(&g->dev, "register_netdev failed, %d\n", status); > return status; > } else { > INFO(dev, "HOST MAC %pM\n", dev->host_mac); > INFO(dev, "MAC %pM\n", dev->dev_mac);
Those need to be moved to be dev_info() and then I'll stop complaining :) Or dev_dbg() if you want to make it debug only.
> ... > } > > > Any objection to just removing completely from gether_setup_name_default()?
Nope!
Remove them and change the above lines and then all should be good.
thanks,
greg k-h
| |