lkml.org 
[lkml]   [2023]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] tick/nohz: Fix cpu_is_hotpluggable() by checking with nohz subsystem
Date


> On Jan 20, 2023, at 2:05 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jan 19, 2023 at 08:44:35PM +0000, Joel Fernandes (Google) wrote:
>> For CONFIG_NO_HZ_FULL systems, the tick_do_timer_cpu cannot be offlined.
>> However, cpu_is_hotpluggable() still returns true for those CPUs. This causes
>> torture tests that do offlining to end up trying to offline this CPU causing
>> test failures. Such failure happens on all architectures.
>>
>> Fix it by asking the opinion of the nohz subsystem on whether the CPU can
>> be hotplugged.
>>
>> [ Apply Frederic Weisbecker feedback on refactoring tick_nohz_cpu_down(). ]
>>
>> Cc: Frederic Weisbecker <frederic@kernel.org>
>> Cc: "Paul E. McKenney" <paulmck@kernel.org>
>> Cc: Zhouyi Zhou <zhouzhouyi@gmail.com>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: Marc Zyngier <maz@kernel.org>
>> Cc: rcu <rcu@vger.kernel.org>
>> Fixes: 2987557f52b9 ("driver-core/cpu: Expose hotpluggability to the rest of the kernel")
>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>
> Also want to cc: stable on the patch?

Oh sure, sorry. For some reason I thought Sasha and your AI scripts were looking at the Linux-kernel list as well. Or are they, and a Cc to stable is just to be doubly sure?

> Anyway, for the driver core portion:

Thanks!

- Joel

>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

\
 
 \ /
  Last update: 2023-03-26 23:49    [W:0.084 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site