lkml.org 
[lkml]   [2023]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 7/8] net: microchip: sparx5: Add support for IS0 VCAP ethernet protocol types
From
Date
Hi Dan,

On Fri, 2023-01-20 at 12:20 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Fri, Jan 20, 2023 at 10:08:30AM +0100, Steen Hegelund wrote:
> > +bool sparx5_vcap_is_known_etype(struct vcap_admin *admin, u16 etype)
> > +{
> > +     const u16 *known_etypes;
> > +     int size, idx;
> > +
> > +     switch (admin->vtype) {
> > +     case VCAP_TYPE_IS0:
> > +             known_etypes = sparx5_vcap_is0_known_etypes;
> > +             size = ARRAY_SIZE(sparx5_vcap_is0_known_etypes);
> > +             break;
> > +     case VCAP_TYPE_IS2:
> > +             known_etypes = sparx5_vcap_is2_known_etypes;
> > +             size = ARRAY_SIZE(sparx5_vcap_is2_known_etypes);
> > +             break;
> > +     default:
> > +             break;
>
> return false; to avoid an uninitialized "size".

Good catch. I will update that.
>
> > +     }
> > +     for (idx = 0; idx < size; ++idx)
> > +             if (known_etypes[idx] == etype)
> > +                     return true;
> > +     return false;
> > +}
>
> regards,
> dan carpenter

Thanks for the review.

BR
Steen


\
 
 \ /
  Last update: 2023-03-26 23:49    [W:0.253 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site