Messages in this thread | | | From | "Sverdlin, Alexander" <> | Subject | Re: [PATCH 1/3] drm/rockchip: lvds: add rk3568 support | Date | Fri, 20 Jan 2023 09:31:43 +0000 |
| |
Hello Sascha,
On Fri, 2023-01-20 at 10:16 +0100, Sascha Hauer wrote: > > + /* Enable LVDS mode */ > > + return regmap_update_bits(lvds->grf, RK3568_GRF_VO_CON2, > > + RK3568_LVDS0_MODE_EN(1), > > + RK3568_LVDS0_MODE_EN(1)); > > Isn't this the same as: > > regmap_write(lvds->grf, RK3568_GRF_VO_CON2, > RK3568_LVDS0_MODE_EN(1)); > > Unless I am missing something I find a plain regmap_write() easier to > read.
the former is setting a bit in a RMW operation, the latter is a plain write, isn't it?
-- Alexander Sverdlin Siemens AG www.siemens.com
| |