lkml.org 
[lkml]   [2023]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] drm/rockchip: lvds: add rk3568 support
Date
Hello Sascha,

On Fri, 2023-01-20 at 10:16 +0100, Sascha Hauer wrote:
> > +       /* Enable LVDS mode */
> > +       return regmap_update_bits(lvds->grf, RK3568_GRF_VO_CON2,
> > +                                 RK3568_LVDS0_MODE_EN(1),
> > +                                 RK3568_LVDS0_MODE_EN(1));
>
> Isn't this the same as:
>
>         regmap_write(lvds->grf, RK3568_GRF_VO_CON2,
> RK3568_LVDS0_MODE_EN(1));
>
> Unless I am missing something I find a plain regmap_write() easier to
> read.

the former is setting a bit in a RMW operation, the latter is a plain
write, isn't it?

--
Alexander Sverdlin
Siemens AG
www.siemens.com
\
 
 \ /
  Last update: 2023-03-26 23:49    [W:0.944 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site