Messages in this thread | | | Date | Fri, 20 Jan 2023 08:47:02 +0100 | Subject | Re: [PATCH 2/2] spi: spidev: add new mediatek support | From | Krzysztof Kozlowski <> |
| |
On 19/01/2023 20:18, Alexandre Mergnat wrote: > Le jeu. 19 janv. 2023 à 17:49, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> a écrit : >> >> On 19/01/2023 17:28, Alexandre Mergnat wrote: >>> { .compatible = "micron,spi-authenta", .data = &spidev_of_check }, >>> + { .compatible = "mediatek,genio", .data = &spidev_of_check }, >> >> Please run scripts/checkpatch.pl and fix reported warnings. > > Actually I did. > I saw: "WARNING: DT compatible string "mediatek,genio" appears > un-documented -- check ./Documentation/devicetree/bindings/" > But there are no bindings for spidev. I've made some grep on already > supported compatible devices like "micron,spi-authenta", but I didn't > find documentation to add "mediatek,genio".
Another point - why is this after "micron"? Don't add entries to the end but in order.
Best regards, Krzysztof
| |