lkml.org 
[lkml]   [2023]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH bpf-next 1/8] bpf: Enable annotating trusted nested pointers
    Hi David,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on bpf-next/master]

    url: https://github.com/intel-lab-lkp/linux/commits/David-Vernet/bpf-Enable-annotating-trusted-nested-pointers/20230120-080139
    base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
    patch link: https://lore.kernel.org/r/20230119235833.2948341-2-void%40manifault.com
    patch subject: [PATCH bpf-next 1/8] bpf: Enable annotating trusted nested pointers
    config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230120/202301201328.KZrjrJXf-lkp@intel.com/config)
    compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/8f6df14342b1be3516f8e21037edf771df851427
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review David-Vernet/bpf-Enable-annotating-trusted-nested-pointers/20230120-080139
    git checkout 8f6df14342b1be3516f8e21037edf771df851427
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/bpf/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    >> kernel/bpf/btf.c:533:5: warning: no previous prototype for function 'bpf_find_btf_id' [-Wmissing-prototypes]
    s32 bpf_find_btf_id(const char *name, u32 kind, struct btf **btf_p)
    ^
    kernel/bpf/btf.c:533:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    s32 bpf_find_btf_id(const char *name, u32 kind, struct btf **btf_p)
    ^
    static
    1 warning generated.


    vim +/bpf_find_btf_id +533 kernel/bpf/btf.c

    532
    > 533 s32 bpf_find_btf_id(const char *name, u32 kind, struct btf **btf_p)
    534 {
    535 struct btf *btf;
    536 s32 ret;
    537 int id;
    538
    539 btf = bpf_get_btf_vmlinux();
    540 if (IS_ERR(btf))
    541 return PTR_ERR(btf);
    542 if (!btf)
    543 return -EINVAL;
    544
    545 ret = btf_find_by_name_kind(btf, name, kind);
    546 /* ret is never zero, since btf_find_by_name_kind returns
    547 * positive btf_id or negative error.
    548 */
    549 if (ret > 0) {
    550 btf_get(btf);
    551 *btf_p = btf;
    552 return ret;
    553 }
    554
    555 /* If name is not found in vmlinux's BTF then search in module's BTFs */
    556 spin_lock_bh(&btf_idr_lock);
    557 idr_for_each_entry(&btf_idr, btf, id) {
    558 if (!btf_is_module(btf))
    559 continue;
    560 /* linear search could be slow hence unlock/lock
    561 * the IDR to avoiding holding it for too long
    562 */
    563 btf_get(btf);
    564 spin_unlock_bh(&btf_idr_lock);
    565 ret = btf_find_by_name_kind(btf, name, kind);
    566 if (ret > 0) {
    567 *btf_p = btf;
    568 return ret;
    569 }
    570 spin_lock_bh(&btf_idr_lock);
    571 btf_put(btf);
    572 }
    573 spin_unlock_bh(&btf_idr_lock);
    574 return ret;
    575 }
    576

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-26 23:48    [W:3.258 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site