lkml.org 
[lkml]   [2023]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 1/1] cifs: Get rid of unneeded conditional in the smb2_get_aead_req()
merged into cifs-2.6.git for-next

On Fri, Jan 20, 2023 at 8:22 AM Paulo Alcantara via samba-technical
<samba-technical@lists.samba.org> wrote:
>
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>
> > In the smb2_get_aead_req() the skip variable is used only for
> > the very first iteration of the two nested loops, which means
> > it's basically in invariant to those loops. Hence, instead of
> > using conditional on each iteration, unconditionally assing
> > the 'skip' variable before the loops and at the end of the
> > inner loop.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > fs/cifs/smb2ops.c | 14 +++++++++-----
> > 1 file changed, 9 insertions(+), 5 deletions(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
>


--
Thanks,

Steve

\
 
 \ /
  Last update: 2023-03-26 23:49    [W:0.054 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site