Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 20 Jan 2023 19:56:03 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v6 03/17] EDAC/qcom: Do not pass llcc_driv_data as edac_device_ctl_info's pvt_info |
| |
On Wed, Jan 18, 2023 at 08:38:50PM +0530, Manivannan Sadhasivam wrote: > The memory for "llcc_driv_data" is allocated by the LLCC driver. But when > it is passed as "pvt_info" to the EDAC core, it will get freed during the > qcom_edac driver release. So when the qcom_edac driver gets probed again, > it will try to use the freed data leading to the use-after-free bug. > > Hence, do not pass "llcc_driv_data" as pvt_info but rather reference it > using the "platform_data" in the qcom_edac driver. > > Cc: <stable@vger.kernel.org> # 4.20 > Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs") > Tested-by: Steev Klimaszewski <steev@kali.org> # Thinkpad X13s > Tested-by: Andrew Halaney <ahalaney@redhat.com> # sa8540p-ride > Reported-by: Steev Klimaszewski <steev@kali.org> > Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/edac/qcom_edac.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)
Applied, thanks.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| ![\](/images/icornerr.gif) |