Messages in this thread | | | Date | Fri, 20 Jan 2023 09:24:18 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function |
| |
On Fri, Jan 20, 2023 at 12:26:04PM +0100, Greg Kroah-Hartman wrote: > On Thu, Dec 22, 2022 at 02:39:50PM +0800, Joe Wu wrote: > > Add 3 extra buttons: 'brightness up', 'brightness down' > > and 'screen lock' to support monitor manipulating function. > > > > Signed-off-by: Joe Wu <joewu@msi.com> > > From: line does not match the signed-off-by (and is an invalid email > address...)
What do you mean "it's an invalid email address"? You can definitely send emails there... I prefer people not to use Google partner domain accounts in the hope that their employment might outlast their involvement in Google projects, but that is it.
I think if we ask people to stick "From: <whatever the company address is" in the body of the patch we can ignore the difference between sender address and from/signed-off-by when they use partner domain accounts. If anything, such accounts have better vetting than a random gmail or other free email service account some vendors have to create to be able to send a plain-text emails that we require. I mean, we have "Signed-off-by: George Spelvin <lkml@sdf.org>" present in our git history and nobody bats an eye...
Thanks.
-- Dmitry
| |