lkml.org 
[lkml]   [2023]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 01/14] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro
    From
    Hello Sam,

    Thanks a lot for your feedback.

    On 1/2/23 19:39, Sam Ravnborg wrote:
    > Hi Javier.
    >
    > On Wed, Dec 28, 2022 at 02:47:44AM +0100, Javier Martinez Canillas wrote:
    >> Many panel drivers define dsi_dcs_write_seq() and dsi_generic_write_seq()
    >> macros to send DCS commands and generic write packets respectively, with
    >> the payload specified as a list of parameters instead of using arrays.
    >>
    >> There's already a macro for the former, introduced by commit 2a9e9daf75231
    >> ("drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro") so drivers can be
    >> changed to use that. But there isn't one yet for the latter, let's add it.
    >>
    >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
    >> ---
    >>
    >> include/drm/drm_mipi_dsi.h | 16 ++++++++++++++++
    >> 1 file changed, 16 insertions(+)
    >>
    >> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
    >> index 20b21b577dea..c7c458131ba1 100644
    >> --- a/include/drm/drm_mipi_dsi.h
    >> +++ b/include/drm/drm_mipi_dsi.h
    >> @@ -297,6 +297,22 @@ int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi,
    >> int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
    >> u16 *brightness);
    >>
    >> +/**
    >> + * mipi_dsi_generic_write - transmit data using a generic write packet
    > s/mipi_dsi_generic_write/mipi_dsi_generic_write_seq
    > (As the bot also reported)
    >

    Ups, sorry for missing that.

    > with this fixed:
    > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
    >

    Thanks!

    >> + * @dsi: DSI peripheral device
    >> + * @seq: buffer containing the payload
    >> + */
    >> +#define mipi_dsi_generic_write_seq(dsi, seq...) do { \
    >> + static const u8 d[] = { seq }; \
    >> + struct device *dev = &dsi->dev; \
    >> + int ret; \
    >> + ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d)); \
    >> + if (ret < 0) { \
    >> + dev_err_ratelimited(dev, "transmit data failed: %d\n", ret); \
    >> + return ret; \
    >> + } \
    >> + } while (0)
    >> +
    > (If you align '\' under each other it would be nicer, but I could see
    > that mipi_dsi_dcs_write_seq() do not do so).

    Yeah, I was actually thinking about doing like you suggested for this macro
    but preferred to keep it consistent with the existing mipi_dsi_dcs_write_seq()
    macro definition...

    Maybe I can add a preparatory patch that just fixes the backslash characters
    indent for mipi_dsi_dcs_write_seq() to be all aligned?

    --
    Best regards,

    Javier Martinez Canillas
    Core Platforms
    Red Hat

    \
     
     \ /
      Last update: 2023-03-26 23:25    [W:6.267 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site