Messages in this thread | ![/](/images/icornerl.gif) | | From | Arend Van Spriel <> | Date | Mon, 02 Jan 2023 19:27:31 +0100 | Subject | Re: [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips |
| |
On January 2, 2023 4:15:41 PM Hector Martin <marcan@marcan.st> wrote:
> On 02/01/2023 23.40, Aditya Garg wrote: >> From: Aditya Garg <gargaditya08@live.com> >> >> Commit 'dce45ded7619' added support for 89459 chip pcie device. It uses the >> BRCM4355 chip which is also found in Apple hardware. However this commit >> causes conflicts in the firmware naming between Apple hardware, which >> supports OTP and other non-Apple hardwares. So, this patch makes these >> Apple chips use their own firmware table so as to avoid possible conflicts >> like these in the future. > > I think my reply to Arend flew over your head. > > My point was that I'd rather have the Broadcom/Cypress people actually > answer my question so we can figure out how to do this *properly*, > instead of doing "safer-but-dumb" things (like this patch) because we > just don't have the information to do it properly.
Fair enough. Can you accurately (re)state your question and I will try to answer it.
Regards, Arend
> - Hector
[unhandled content-type:application/pkcs7-signature] | ![\](/images/icornerr.gif) |