Messages in this thread | | | Date | Mon, 2 Jan 2023 16:59:39 +0100 | From | Jan Kara <> | Subject | Re: [PATCH RESEND v2 08/10] block, bfq: remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq |
| |
On Fri 23-12-22 03:16:39, Kemeng Shi wrote: > We jump to tag only for returning current rq. Return directly to > remove this tag. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
One nit below.
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 89995815dbae..195cdc6be087 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -4965,7 +4965,7 @@ static struct request *bfq_dispatch_rq_from_bfqq(struct bfq_data *bfqd, > bfq_dispatch_remove(bfqd->queue, rq); > > if (bfqq != bfqd->in_service_queue) > - goto return_rq; > + return rq; > > /* > * If weight raising has to terminate for bfqq, then next > @@ -4985,12 +4985,9 @@ static struct request *bfq_dispatch_rq_from_bfqq(struct bfq_data *bfqd, > * belongs to CLASS_IDLE and other queues are waiting for > * service. > */ > - if (!(bfq_tot_busy_queues(bfqd) > 1 && bfq_class_idle(bfqq))) > - goto return_rq; > + if ((bfq_tot_busy_queues(bfqd) > 1 && bfq_class_idle(bfqq))) ^ unnecessary brace here
Honza
> + bfq_bfqq_expire(bfqd, bfqq, false, BFQQE_BUDGET_EXHAUSTED); > > - bfq_bfqq_expire(bfqd, bfqq, false, BFQQE_BUDGET_EXHAUSTED); > - > -return_rq: > return rq; > } > > -- > 2.30.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |