Messages in this thread | | | Date | Mon, 2 Jan 2023 13:42:28 +0100 | From | David Sterba <> | Subject | Re: [PATCH 8/8] btrfs: turn on -Wmaybe-uninitialized |
| |
On Mon, Dec 26, 2022 at 07:34:51PM +0530, Naresh Kamboju wrote: > On Mon, 26 Dec 2022 at 09:47, Nathan Chancellor <nathan@kernel.org> wrote: > > > > On Fri, Dec 16, 2022 at 03:15:58PM -0500, Josef Bacik wrote: > > > We had a recent bug that would have been caught by a newer compiler with > > > -Wmaybe-uninitialized and would have saved us a month of failing tests > > > that I didn't have time to investigate. > > > > > > Signed-off-by: Josef Bacik <josef@toxicpanda.com> > > > > This needs to be moved to the condflags section, as > > -Wmaybe-uninitialized is a GCC only flag, so this breaks our builds with > > clang on next-20221226: > > > > error: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Werror,-Wunknown-warning-option] > > LKFT test farm also noticed these build breaks with clang on next-20221226.
Fixed in our branch and for-next snapshot updated so the warnings will be fixed once linux-next resumes.
| |