Messages in this thread | | | From | Miquel Raynal <> | Subject | Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone | Date | Mon, 2 Jan 2023 12:17:29 +0100 |
| |
On Tue, 2022-12-20 at 14:13:34 UTC, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver > fails to build, as it includes the shared CFI header: > > include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp] > 62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. > > linux/mtd/spi-nor.h does not actually need to include cfi.h, so > remove the inclusion here to fix the warning. This uncovers a > missing #include in spi-nor/core.c so add that there to > prevent a different build issue. > > Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Reviewed-by: Tokunori Ikegami <ikegami.t@gmail.com> > Acked-by: Pratyush Yadav <pratyush@kernel.org> > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel
| |