Messages in this thread | | | Date | Thu, 19 Jan 2023 18:46:30 +0100 | Subject | Re: [PATCH 2/2] soc: mediatek: pm-domains: Add buck isolation setting in power domain | From | Matthias Brugger <> |
| |
On 17/01/2023 04:26, Allen-KH Cheng wrote: > In some chipsets, we need to disable EXT_BUCK_ISO before turning on the > specific power pm-domains (mtcmos), such as ADSP in MT8192 and CAM_VCORE > in MT8188. > > Add the MTK_SCPD_EXT_BUCK_ISO flag to control the buck isolation setting > in the mediatek power domain driver. > > Fixes: 59b644b01cf4 ("soc: mediatek: Add MediaTek SCPSYS power domains")
From my understanding this patch does not fix anything. It's a feature needed for new HW not supported by the mentioned commit. I applied the patch but droppend the Fixes tag. If you do not agree, please explain why we need it.
Regards, Matthias
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > --- > drivers/soc/mediatek/mtk-pm-domains.c | 8 ++++++++ > drivers/soc/mediatek/mtk-pm-domains.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c > index 474b272f9b02..be972e35b26e 100644 > --- a/drivers/soc/mediatek/mtk-pm-domains.c > +++ b/drivers/soc/mediatek/mtk-pm-domains.c > @@ -218,6 +218,10 @@ static int scpsys_power_on(struct generic_pm_domain *genpd) > if (ret) > goto err_reg; > > + if (pd->data->ext_buck_iso_offs && MTK_SCPD_CAPS(pd, MTK_SCPD_EXT_BUCK_ISO)) > + regmap_clear_bits(scpsys->base, pd->data->ext_buck_iso_offs, > + pd->data->ext_buck_iso_mask); > + > /* subsys power on */ > regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_BIT); > regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_2ND_BIT); > @@ -272,6 +276,10 @@ static int scpsys_power_off(struct generic_pm_domain *genpd) > if (ret < 0) > return ret; > > + if (pd->data->ext_buck_iso_offs && MTK_SCPD_CAPS(pd, MTK_SCPD_EXT_BUCK_ISO)) > + regmap_set_bits(scpsys->base, pd->data->ext_buck_iso_offs, > + pd->data->ext_buck_iso_mask); > + > clk_bulk_disable_unprepare(pd->num_subsys_clks, pd->subsys_clks); > > /* subsys power off */ > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h > index a5f24c58e35a..5ec53ee073c4 100644 > --- a/drivers/soc/mediatek/mtk-pm-domains.h > +++ b/drivers/soc/mediatek/mtk-pm-domains.h > @@ -10,6 +10,7 @@ > #define MTK_SCPD_DOMAIN_SUPPLY BIT(4) > /* can't set MTK_SCPD_KEEP_DEFAULT_OFF at the same time */ > #define MTK_SCPD_ALWAYS_ON BIT(5) > +#define MTK_SCPD_EXT_BUCK_ISO BIT(6) > #define MTK_SCPD_CAPS(_scpd, _x) ((_scpd)->data->caps & (_x)) > > #define SPM_VDE_PWR_CON 0x0210
| |