Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 19 Jan 2023 18:27:04 +0100 | Subject | Re: [PATCH v8 0/6] Add MediaTek MT6357 PMIC support | From | Matthias Brugger <> |
| |
Given the ACK in the series I took the bindings and driver through v6.2-next/soc and the DTS changes through v6.2-next/dts64
Thanks!
On 02/01/2023 17:06, Alexandre Mergnat wrote: > Hi, > This patch series adds MFD, PMIC keys, and regulator support for MT6357. > MT6357 is a MediaTek PMIC very similar to MT6358. > > Currently, MTK bindings related to the PMICs are not converted yet (still .txt): > > soc/mediatek/pwrap.txt (all PMIC parent) > | > V > mfd/mt6397.txt (support lot of mt63XX PMIC) > +---------------+----------------+---... > V V V > regulator/... rtc/... codec/... > > 1) Convert pwrap to yaml is ok. > > 2) For the PMIC bindings, there are two option: > - Convert mt6397.txt to mediatek,mt6397.yaml and continue to support multiple > PMIC with only one file. IMO, the file will be hard to read because > the supported features aren't the same for each PMIC. > > - Make a binding file for each PMIC ref: > - mfd/mediatek,mt6357.yaml > - mfd/mediatek,mt6358.yaml > - ... > > 3) All PMIC daughter bindings (regulator, rtc, codec, led, ...) aren't fully > converted yet. Refering to the two PMIC convertion options above: > - To be clean, all daughter bindings should be converted. This is hard because > a good understanding of each device is requiered to write efficient bindings. > - Only daughter bindings supported by the added PMIC should be converted, that > allows to do the task conversion step by step. > > In the V4 of this serie, I chose the second option. > > Regards, > Alex > > Changes in v8: > - Remove the 2 applied patches (v6.2-rc1) from the serie. > - regulator: dt-bindings: Add binding schema for mt6357 regulators > - regulator: add mt6357 regulator > - Rebase from v6.2-tmp/soc branch, got from kernel/git/matthias.bgg/linux.git > - Link to v7: https://lore.kernel.org/r/20221005-mt6357-support-v7-0-477e60126749@baylibre.com > > Changes in v7: > - Drop mt6397 RTC schema conversion. > - Integrate mt6357 RTC schema directly in mediatek,mt6357.yaml. > - Fix unit address in mediatek,pwrap.yaml. > - Link to v6: https://lore.kernel.org/r/20221005-mt6357-support-v6-0-4f589756befa@baylibre.com > > Changes in v6: > - Fix typo in documentations. > - Remove mediatek,mt6397-rtc.yaml example. > - Align pwrap convertion with the original .txt file. > - Remove unecessary include in the mt6357-regulator driver. > - Link to v5: https://lore.kernel.org/r/20221005-mt6357-support-v5-0-8210d955dd3d@baylibre.com > > Changes in v5: > - Add missing maintainers > - Improve RTC binding by adding rtc.yaml ref and start-year property > - Split the txt->yaml conversion in one commit and the addition of the > new mt6357-rtc compatible in another commit. > - Improve PWRAP binding: > - clocks and clock-name have been refactored. > - reset-names is now properly dependent to resets. > - additionalProperties change from true to false. > - change example for a most recent and popular SoC. > - "allOf" part has been simplified. > - Pass binding tests with the updated tools. Here the command: > "make DT_CHECKER_FLAGS=-m dt_binding_check" > - Link to v4: https://lore.kernel.org/r/20221005-mt6357-support-v4-0-5d2bb58e6087@baylibre.com > > Changes in v4: > - "dt-bindings: mfd: mt6397: add binding for MT6357" has been applied > by Lee Jones > - All fixed regulator are now refering to fixed-regulator.yaml > - vfe28 and vcamio18 regulators have been added > - pwrap binding has been converted and mt8365 support has been added > - mt6357 PMIC binding has been created > - mt6397 RTC binding has been converted and mt6357 support has been added > - Link to v3: https://lore.kernel.org/r/20221005-mt6357-support-v3-0-7e0bd7c315b2@baylibre.com > > Changes in v3: > - To be consistent with regulator/driver.h and helper.c, shift > variables have been removed and the mask values have been directly shifted. > - Remove index tables and rework volt tables to use set/get helper functions. > - Add comment to structure and function. > - Fix Fabien Parent mail address. > - Link to v2: https://lore.kernel.org/r/20221005-mt6357-support-v2-0-f17ba2d2d0a9@baylibre.com > > Changes in v2: > - Rebase > - Fix typo > - Remove dependencies with https://lore.kernel.org/all/20220415153629.1817202-1-fparent@baylibre.com/ > which is no longer relevant. > > Previous versions: > v1 - https://lore.kernel.org/all/20220531124959.202787-1-fparent@baylibre.com/ > > To: Lee Jones <lee@kernel.org> > To: Rob Herring <robh+dt@kernel.org> > To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > To: Matthias Brugger <matthias.bgg@gmail.com> > To: Dmitry Torokhov <dmitry.torokhov@gmail.com> > To: Chen Zhong <chen.zhong@mediatek.com> > To: Liam Girdwood <lgirdwood@gmail.com> > To: Mark Brown <broonie@kernel.org> > To: Fabien Parent <fabien.parent@linaro.org> > To: Alessandro Zummo <a.zummo@towertech.it> > To: Alexandre Belloni <alexandre.belloni@bootlin.com> > To: Sean Wang <sean.wang@mediatek.com> > To: Pavel Machek <pavel@ucw.cz> > To: Tianping Fang <tianping.fang@mediatek.com> > To: Flora Fu <flora.fu@mediatek.com> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-input@vger.kernel.org > Cc: Fabien Parent <fparent@baylibre.com> > Cc: Rob Herring <robh@kernel.org> > Cc: linux-rtc@vger.kernel.org > Cc: linux-leds@vger.kernel.org > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > --- > Alexandre Mergnat (4): > dt-bindings: soc: mediatek: convert pwrap documentation > dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC > arm64: dts: mt6358: change node names > arm64: dts: mt8173: change node name > > Fabien Parent (2): > dt-bindings: input: mtk-pmic-keys: add binding for MT6357 PMIC > Input: mtk-pmic-keys: add MT6357 support > > .../bindings/input/mediatek,pmic-keys.yaml | 1 + > .../devicetree/bindings/leds/leds-mt6323.txt | 2 +- > .../devicetree/bindings/mfd/mediatek,mt6357.yaml | 111 ++++++++++++++++ > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > .../bindings/soc/mediatek/mediatek,pwrap.yaml | 147 +++++++++++++++++++++ > .../devicetree/bindings/soc/mediatek/pwrap.txt | 75 ----------- > arch/arm64/boot/dts/mediatek/mt6358.dtsi | 6 +- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 2 +- > drivers/input/keyboard/mtk-pmic-keys.c | 17 +++ > 10 files changed, 283 insertions(+), 82 deletions(-) > --- > base-commit: e32caddfc737a96f6593754c2a08be6b8c1e0cec > change-id: 20221005-mt6357-support-55308b82e33f > > Best regards,
| ![\](/images/icornerr.gif) |