lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
From
Date
Hi,

On Wed, 2023-01-18 at 15:24 +0530, Siddharth Vadapalli wrote:
> @@ -1014,18 +1013,12 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
> }
> cpts->phc_index = ptp_clock_index(cpts->ptp_clock);
>
> - ret = devm_add_action_or_reset(dev, am65_cpts_release, cpts);
> - if (ret) {
> - dev_err(dev, "failed to add ptpclk reset action %d", ret);
> - return ERR_PTR(ret);
> - }
> -
> ret = devm_request_threaded_irq(dev, cpts->irq, NULL,
> am65_cpts_interrupt,
> IRQF_ONESHOT, dev_name(dev), cpts);
> if (ret < 0) {
> dev_err(cpts->dev, "error attaching irq %d\n", ret);
> - return ERR_PTR(ret);
> + goto reset_ptpclk;
> }
>
> dev_info(dev, "CPTS ver 0x%08x, freq:%u, add_val:%u\n",

This chunk does not apply cleanly to current net-next (context is
changed). Please rebase and re-spin (you can preserve/keep the already
acquire reviewed-by tags)

Thanks!

Paolo

\
 
 \ /
  Last update: 2023-03-26 23:47    [W:0.672 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site