lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v9 04/15] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings
From
On 19/01/2023 04:51, Brad Larson wrote:
> The AMD Pensando Elba SoC has integrated the DW APB SPI Controller
>
> Signed-off-by: Brad Larson <blarson@amd.com>
> ---
>
> Changes since v6:
> - Define property amd,pensando-elba-syscon
> - Move compatible amd,pensando-elba-spi ahead of baikal,bt1-ssi
>
> ---
> .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index d33b72fabc5d..96b072835de0 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -37,6 +37,18 @@ allOf:
> else:
> required:
> - interrupts
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: amd,pensando-elba-spi
> + then:
> + properties:
> + amd,pensando-elba-syscon:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: AMD Pensando Elba SoC system controller

And nothing here - neither in commit msg nor here - explains why do you
need it and what is it for.

Define properties in top level "properties:" and here only allow (:
true) or disallow (: false) them.

> + required:
> + - amd,pensando-elba-syscon
>
> properties:
> compatible:
> @@ -63,6 +75,8 @@ properties:
> const: intel,keembay-ssi
> - description: Intel Thunder Bay SPI Controller
> const: intel,thunderbay-ssi
> + - description: AMD Pensando Elba SoC SPI Controller
> + const: amd,pensando-elba-spi
> - description: Baikal-T1 SPI Controller
> const: baikal,bt1-ssi
> - description: Baikal-T1 System Boot SPI Controller

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-26 23:47    [W:0.139 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site