lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 6/9] pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code
    Date
    Use DEFINE_SHOW_ATTRIBUTE() helper macro to simplify the code.
    No functional change.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/block/pktcdvd.c | 23 +++--------------------
    1 file changed, 3 insertions(+), 20 deletions(-)

    diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
    index a53d21dbf2ab..2c5441303e55 100644
    --- a/drivers/block/pktcdvd.c
    +++ b/drivers/block/pktcdvd.c
    @@ -504,24 +504,7 @@ static int pkt_seq_show(struct seq_file *m, void *p)
    pd->write_congestion_on);
    return 0;
    }
    -
    -static int pkt_debugfs_seq_show(struct seq_file *m, void *p)
    -{
    - return pkt_seq_show(m, p);
    -}
    -
    -static int pkt_debugfs_fops_open(struct inode *inode, struct file *file)
    -{
    - return single_open(file, pkt_debugfs_seq_show, inode->i_private);
    -}
    -
    -static const struct file_operations debug_fops = {
    - .open = pkt_debugfs_fops_open,
    - .read = seq_read,
    - .llseek = seq_lseek,
    - .release = single_release,
    - .owner = THIS_MODULE,
    -};
    +DEFINE_SHOW_ATTRIBUTE(pkt_seq);

    static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
    {
    @@ -531,8 +514,8 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
    if (!pd->dfs_d_root)
    return;

    - pd->dfs_f_info = debugfs_create_file("info", 0444,
    - pd->dfs_d_root, pd, &debug_fops);
    + pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
    + pd, &pkt_seq_fops);
    }

    static void pkt_debugfs_dev_remove(struct pktcdvd_device *pd)
    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-26 23:48    [W:6.329 / U:19.840 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site