lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 3/9] pktcdvd: use sysfs_emit() to instead of scnprintf()
    Date
    Follow the advice of the Documentation/filesystems/sysfs.rst and show()
    should only use sysfs_emit() or sysfs_emit_at() when formatting the
    value to be returned to user space.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/block/pktcdvd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
    index ad4336ae9927..98a5c388eabf 100644
    --- a/drivers/block/pktcdvd.c
    +++ b/drivers/block/pktcdvd.c
    @@ -339,7 +339,7 @@ static ssize_t device_map_show(struct class *c, struct class_attribute *attr,
    struct pktcdvd_device *pd = pkt_devs[idx];
    if (!pd)
    continue;
    - n += sprintf(data+n, "%s %u:%u %u:%u\n",
    + n += sysfs_emit_at(data, n, "%s %u:%u %u:%u\n",
    pd->disk->disk_name,
    MAJOR(pd->pkt_dev), MINOR(pd->pkt_dev),
    MAJOR(pd->bdev->bd_dev),
    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-26 23:48    [W:2.136 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site