Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 19 Jan 2023 15:14:25 -0500 | Subject | Re: [PATCH v1] perf tools: Fix foolproof typo | From | "Liang, Kan" <> |
| |
On 2023-01-19 3:10 p.m., Ian Rogers wrote: > In the context of LBR stitching documentation. > > Signed-off-by: Ian Rogers <irogers@google.com>
Thanks Ian.
Acked-by: Kan Liang <kan.liang@linux.intel.com>
Thanks, Kan
> --- > tools/perf/Documentation/perf-c2c.txt | 2 +- > tools/perf/Documentation/perf-report.txt | 2 +- > tools/perf/Documentation/perf-script.txt | 2 +- > tools/perf/Documentation/perf-top.txt | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt > index 5c5eb2def83e..af5c3106f468 100644 > --- a/tools/perf/Documentation/perf-c2c.txt > +++ b/tools/perf/Documentation/perf-c2c.txt > @@ -121,7 +121,7 @@ REPORT OPTIONS > perf c2c record --call-graph lbr. > Disabled by default. In common cases with call stack overflows, > it can recreate better call stacks than the default lbr call stack > - output. But this approach is not full proof. There can be cases > + output. But this approach is not foolproof. There can be cases > where it creates incorrect call stacks from incorrect matches. > The known limitations include exception handing such as > setjmp/longjmp will have calls/returns not match. > diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt > index 4fa509b15948..9b0c0dbf9a77 100644 > --- a/tools/perf/Documentation/perf-report.txt > +++ b/tools/perf/Documentation/perf-report.txt > @@ -507,7 +507,7 @@ include::itrace.txt[] > perf record --call-graph lbr. > Disabled by default. In common cases with call stack overflows, > it can recreate better call stacks than the default lbr call stack > - output. But this approach is not full proof. There can be cases > + output. But this approach is not foolproof. There can be cases > where it creates incorrect call stacks from incorrect matches. > The known limitations include exception handing such as > setjmp/longjmp will have calls/returns not match. > diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt > index 68e37de5fae4..8d77182fbf31 100644 > --- a/tools/perf/Documentation/perf-script.txt > +++ b/tools/perf/Documentation/perf-script.txt > @@ -502,7 +502,7 @@ include::itrace.txt[] > perf record --call-graph lbr. > Disabled by default. In common cases with call stack overflows, > it can recreate better call stacks than the default lbr call stack > - output. But this approach is not full proof. There can be cases > + output. But this approach is not foolproof. There can be cases > where it creates incorrect call stacks from incorrect matches. > The known limitations include exception handing such as > setjmp/longjmp will have calls/returns not match. > diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt > index e534d709cc5a..c60e615b7183 100644 > --- a/tools/perf/Documentation/perf-top.txt > +++ b/tools/perf/Documentation/perf-top.txt > @@ -334,7 +334,7 @@ use '-e e1 -e e2 -G foo,foo' or just use '-e e1 -e e2 -G foo'. > callgraph. The option must be used with --call-graph lbr recording. > Disabled by default. In common cases with call stack overflows, > it can recreate better call stacks than the default lbr call stack > - output. But this approach is not full proof. There can be cases > + output. But this approach is not foolproof. There can be cases > where it creates incorrect call stacks from incorrect matches. > The known limitations include exception handing such as > setjmp/longjmp will have calls/returns not match.
| ![\](/images/icornerr.gif) |