Messages in this thread | | | From | Alexandre Mergnat <> | Date | Thu, 19 Jan 2023 20:30:15 +0100 | Subject | Re: [PATCH v2 2/2] spi: spidev: add new mediatek support |
| |
Le jeu. 19 janv. 2023 à 18:36, Mark Brown <broonie@kernel.org> a écrit : > > On Thu, Jan 19, 2023 at 06:28:20PM +0100, Alexandre Mergnat wrote: > > Add the "mediatek,genio" compatible string to support Mediatek > > SPI controller on the genio boards. > > All my previous review comments stand, please don't ignore review > feedback.
Hi Mark,
Yes sorry about that, I wasn't aware that I've some feedback when I sent V2 for a quickfix.
I will take care about your comment:
> We need a matching update to the binding document. > > This does also seem like a terribly generic name - Google > suggests that this is actually a series of numbered products (eg, > Genio 700), perhaps we should be using the specific numbers here? > I guess users would care which they're talking to. It really > parses as being "generic I/O" which would be an end run around > describing the actual product though it's not actually that.
Is there a binding documentation for spidev ? I didn't find it.
My understanding is to have something more specific like: compatible = "mediatek,genio350" Or maybe use the SoC name, to be aligned with the DTS ? compatible = "mediatek,spi-mt8365"
Regards, Alex
| |