Messages in this thread | | | Date | Wed, 18 Jan 2023 15:00:55 +0100 | Subject | Re: [PATCH v4 13/17] arm64: dts: freescale: apalis-imx8: add bkl1_pwm functionality | From | Krzysztof Kozlowski <> |
| |
On 18/01/2023 08:26, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Add Apalis BKL1_PWM functionality. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > > Changes in v4: > - New patch adding Apalis BKL1_PWM functionality. > > arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi | 7 ++++++- > .../arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 7 ++++++- > .../arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 7 ++++++- > arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 9 +++++++-- > 4 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > index 060454f25c98..003bc5377ce7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > @@ -106,7 +106,12 @@ &lsio_pwm3 { > > /* TODO: Apalis PCIE1 */ > > -/* TODO: Apalis BKL1_PWM */ > +/* Apalis BKL1_PWM */ > +&pwm_lvds1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm_bkl>; > + status = "okay";
You just added this file with that comment. This does not make sense. The same patchset adding a line and them immediately changing it. It means previous patch is incomplete or buggy. This must be squashed.
Best regards, Krzysztof
| |