lkml.org 
[lkml]   [2023]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] HID: i2c-hid: use standard debugging APIs
On Fri, 23 Dec 2022, Thomas Weißschuh wrote:

> When trying to debug i2c-hid I was not able to use the builtin debug
> mechanism because the "debug" module parameter is not writable.
>
> We can change i2c-hid to use the standard kernel debugging APIs which are
> more discoverable and have more features.
>
> There is a bit of a stilistic conflict between consistently using
> i2c_hid_dbg() and consistently using dev_<level>().
>
> The second patch aligns debugging on i2c_hid_dbg().
> If this is unneeded, feel free to drop it.
>
> It would also be easy to just use dev_dbg() everywhere for consistency.
>
> To: Jiri Kosina <jikos@kernel.org>
> To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>
> ---
> Thomas Weißschuh (2):
> HID: i2c-hid: switch to standard debugging APIs
> HID: i2c-hid: use uniform debugging APIs
>
> drivers/hid/i2c-hid/i2c-hid-core.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)

Applied to for-6.3/i2c-hid branch, thanks Thomas.

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2023-03-26 23:45    [W:0.145 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site