| Date | Wed, 18 Jan 2023 18:37:45 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits |
| |
On Wed, Jan 18, 2023 at 05:37:19PM +0800, Kemeng Shi wrote: > +/* > + * blk_mq_commit_rqs will notify driver using bd->last that there is no > + * more requests. (See comment in struct blk_mq_ops for commit_rqs for > + * details) > + * Attention, we should explicitly call this in unusual cases: > + * 1) did not queue everything initially scheduled to queue > + * 2) the last attempt to queue a request failed > + */ > +static void blk_mq_commit_rqs(struct blk_mq_hw_ctx *hctx, int queued, > + bool from_schedule)
Isn't from_schedule always false here as well now?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
|