lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] qla2xxx: fix printk format string
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    Printing a size_t value that is the result of the sizeof() operator requires
    using the %z format string modifier to avoid a warning on 32-bit architectures:

    drivers/scsi/qla2xxx/qla_mid.c: In function 'qla_create_buf_pool':
    drivers/scsi/qla2xxx/qla_mid.c:1094:51: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'unsigned int' [-Werror=format=]
    1094 | "Failed to allocate buf_map(%ld).\n", sz * sizeof(unsigned long));
    | ~~^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    | | |
    | long int unsigned int
    | %d

    Fixes: 82d8dfd2a238 ("scsi: qla2xxx: edif: Fix performance dip due to lock contention")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/scsi/qla2xxx/qla_mid.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mid.c
    index c6ca39b8e23d..1483f6258f92 100644
    --- a/drivers/scsi/qla2xxx/qla_mid.c
    +++ b/drivers/scsi/qla2xxx/qla_mid.c
    @@ -1091,7 +1091,7 @@ int qla_create_buf_pool(struct scsi_qla_host *vha, struct qla_qpair *qp)
    qp->buf_pool.buf_map = kcalloc(sz, sizeof(long), GFP_KERNEL);
    if (!qp->buf_pool.buf_map) {
    ql_log(ql_log_warn, vha, 0x0186,
    - "Failed to allocate buf_map(%ld).\n", sz * sizeof(unsigned long));
    + "Failed to allocate buf_map(%zd).\n", sz * sizeof(unsigned long));
    return -ENOMEM;
    }
    sz = qp->req->length * sizeof(void *);
    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-26 23:44    [W:7.018 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site