lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight
On Tue, Jan 17, 2023 at 09:47:42PM +0800, Jianhua Lu wrote:
> Add Kinetic KTZ8866 backlight binding documentation.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>

Might be a good idea to take a look at this bit of the docs because
the patchset is not in the right order (I.5):
https://docs.kernel.org/devicetree/bindings/submitting-patches.html


> ---
> Changes in v2:
> - Remove "items" between "compatible" and "const: kinetic,ktz8866"
> - Change "additionalProperties" to "unevaluatedProperties"
>
> Changes in v3:
> - Add Krzysztof's R-b
>
> Changes in v4:
> - Drop Krzysztof's R-b
> - Add some new properties
>
> .../leds/backlight/kinetic,ktz8866.yaml | 54 +++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> new file mode 100644
> index 000000000000..18571d69accb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kinetic Technologies KTZ8866 backlight
> +
> +maintainers:
> + - Jianhua Lu <lujianhua000@gmail.com>
> +
> +description: |
> + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight
> + with dual lcd bias power.
> + https://www.kinet-ic.com/ktz8866/
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> + const: kinetic,ktz8866
> +
> + current-num-sinks:
> + description: Number of LED current sinks.
> +
> + current-ramping-time:
> + description: LED current ramping time.

Needs to document know what units this value is expressed in. IIRC
this should be expressed in SI units and included the property name.
Something like:

current-ramping-time-us:
description: LED current ramping time in microseconds.


> +
> + led-ramping-time:
> + description: LED on/off ramping time.

+1


Daniel.

\
 
 \ /
  Last update: 2023-03-26 23:44    [W:0.057 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site