Messages in this thread | | | Date | Tue, 17 Jan 2023 15:13:04 +0100 | Subject | Re: [PATCH V2 2/2] usb: gadget: u_ether: Don't warn in gether_setup_name_default() | From | Andrzej Pietrasiewicz <> |
| |
Hi,
W dniu 16.01.2023 o 16:55, Jon Hunter pisze: > The function gether_setup_name_default() is called by various USB > ethernet gadget drivers. This function always generates the MAC address > for the ethernet gadget device and always prints a warning when > generating the MAC address. Given that these messages are expected, make > these debug prints instead of warnings. > > Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> --- > V1 -> V2: Changed print to debug instead of info. > > drivers/usb/gadget/function/u_ether.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c > index be8e7b448933..8feb40e38137 100644 > --- a/drivers/usb/gadget/function/u_ether.c > +++ b/drivers/usb/gadget/function/u_ether.c > @@ -845,13 +845,13 @@ struct net_device *gether_setup_name_default(const char *netname) > snprintf(net->name, sizeof(net->name), "%s%%d", netname); > > eth_random_addr(dev->dev_mac); > - pr_warn("using random self ethernet address %pM\n", dev->dev_mac); > + pr_debug("using random self ethernet address %pM\n", dev->dev_mac); > > /* by default we always have a random MAC address */ > net->addr_assign_type = NET_ADDR_RANDOM; > > eth_random_addr(dev->host_mac); > - pr_warn("using random host ethernet address %pM\n", dev->host_mac); > + pr_debug("using random host ethernet address %pM\n", dev->host_mac); > > net->netdev_ops = ð_netdev_ops; >
| |