lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/2] gpio: vf610: Support building gpio-vf610 driver as module
Date
> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: 2022年12月29日 9:46
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: brgl@bgdev.pl; stefan@agner.ch; linux-gpio@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] gpio: vf610: Support building gpio-vf610 driver as
> module
>
> On Tue, Dec 20, 2022 at 10:02 AM <haibo.chen@nxp.com> wrote:
>
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > To support Android GKI, need to build this driver as module.
> > So change the config as tristate type, and add module license.
> >
> > Signed-off-by: Jindong Yue <jindong.yue@nxp.com>
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>
> OK...
>
> > builtin_platform_driver(vf610_gpio_driver);
>
> Then you want something like module_platform_driver() here.

Hi Linus,

Here, though need to build this gpio driver as module due to the Android GKI, but we do not really need to
rmmod/unbind this driver, so do not need to implement the _exit or remove callback.
In this case, still need to change to module_platform_driver()?
If so, after use the module_platform_driver(), is it okay to not implement the __exit /remove callback?

Best Regards
Haibo Chen
>
> Yours,
> Linus Walleij
\
 
 \ /
  Last update: 2023-03-26 23:44    [W:0.119 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site