Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 17 Jan 2023 13:52:19 +0100 | Subject | Re: [PATCH 2/4] arm64: dts: mediatek: add i2c support for mt8365 SoC | From | AngeloGioacchino Del Regno <> |
| |
Il 17/01/23 09:49, Alexandre Mergnat ha scritto: > There are four I2C master channels in MT8365 with a same HW architecture. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8365.dtsi | 60 ++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > index a32f2b7507be..3c2819bd32af 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > @@ -282,6 +282,66 @@ pwm: pwm@11006000 { > clock-names = "top", "main", "pwm1", "pwm2", "pwm3"; > }; > > + i2c0: i2c@11007000 { > + compatible = "mediatek,mt8365-i2c", > + "mediatek,mt8168-i2c"; > + reg = <0 0x11007000 0 0xa0>, > + <0 0x11000080 0 0x80>;
Compatibles fit in one line (83 columns is fine); regs fit in one line, reaching 76 columns.
Same comments for the other nodes that you're adding.
Regards, Angelo
| ![\](/images/icornerr.gif) |