lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v11 0/5] Add support for CDNS DSI J721E wrapper
From
Hi,

On 03/01/2023 12:19, Rahul T R wrote:
> Following series of patches adds supports for CDNS DSI
> bridge on j721e.
>
> v11:
> - Wrap commmit messages at 72 chars
> - Fix the order in Kconfig and Makefile
> - Clean up the includes, move macros and some headers to .c file
> - Add missing forward declarations
> - Add __ prefix to header gaurds
> - Change dsi_platform_ops to cdns_dsi_platform_ops
> - Add documentation to struct cdns_dsi_platform_ops
>
> v10:
> - Rebased to v6.2-rc1
> - Accumulated the Reviewed-by acks
>
> v9:
> - Fixed below based on review comments in v8
> - Added more info on wrapper in the commit message
> - Fixed the description in Kconfig
> - Fixed the formatting of of_match table
> - exit -> deinit in platform ops
> - Remove duplicate of struct declaration in cdns-dsi-j721e.h
>
> v8:
> - Rebased to 6.1-rc1
>
> v7:
> - Rebased to next-20220920
> - Accumulated the Reviewed-by acks
>
> v6:
> - Dropped generic definations for properties like reg, resets etc..
> - Fixed the defination for port@0 and port@1
> - removed the ti,sn65dsi86 node from the example, which is not related
>
> v5:
> - Remove power-domain property in the conversion commit
> - Add power-domain only for j721e compatible
> - Fix white space error in one of the commit
>
> v4:
> - split conversion txt to yaml
> - seperate commit for addinig new compatible
> - conditionally limit the items for reg property, based on the compatible
>
> v3:
> - Convert cdns-dsi.txt binding to yaml
> - Move the bridge under display/bridge/cadence
> - Add new compatible to enable the wrapper module
>
> v2:
> - Moved setting DPI0 to bridge_enable, since it
> should be done after pm_runtime_get
>
> Rahul T R (5):
> dt-bindings: display: bridge: Convert cdns,dsi.txt to yaml
> dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on
> j721e
> drm/bridge: cdns-dsi: Move to drm/bridge/cadence
> drm/bridge: cdns-dsi: Create a header file
> drm/bridge: cdns-dsi: Add support for J721E wrapper
>
> .../bindings/display/bridge/cdns,dsi.txt | 112 -----------
> .../bindings/display/bridge/cdns,dsi.yaml | 180 ++++++++++++++++++
> drivers/gpu/drm/bridge/Kconfig | 11 --
> drivers/gpu/drm/bridge/Makefile | 1 -
> drivers/gpu/drm/bridge/cadence/Kconfig | 21 ++
> drivers/gpu/drm/bridge/cadence/Makefile | 3 +
> .../{cdns-dsi.c => cadence/cdns-dsi-core.c} | 83 ++++----
> .../gpu/drm/bridge/cadence/cdns-dsi-core.h | 84 ++++++++
> .../gpu/drm/bridge/cadence/cdns-dsi-j721e.c | 51 +++++
> .../gpu/drm/bridge/cadence/cdns-dsi-j721e.h | 16 ++
> 10 files changed, 391 insertions(+), 171 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt
> create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> rename drivers/gpu/drm/bridge/{cdns-dsi.c => cadence/cdns-dsi-core.c} (97%)
> create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h
> create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.c
> create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.h
>

Looks good to me. As Andrzej gave his Rb, I presume it's fine for me to
push this to drm-misc-next. I'll do this a bit later today.

There was a small typo in the 5th patch, about which checkpatch gave a
warning. I'll fix that while applying.

Tomi

\
 
 \ /
  Last update: 2023-03-26 23:44    [W:0.091 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site