lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties
From
On 16/01/2023 10:25, Konrad Dybcio wrote:
> Allow regulator-common properties on lab/ibb regulators, such as
> regulator-always-on, etc.

Are these proper regulators? If so this looks sensible. Why calling it
RFC? What is here questionable?

>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../bindings/regulator/qcom-labibb-regulator.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> index f97b8083678f..c0be7d5a6d40 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
> @@ -20,7 +20,8 @@ properties:
>
> lab:
> type: object
> - additionalProperties: false
> + $ref: "regulator.yaml#"

Drop quotes.

> + unevaluatedProperties: false
>
> properties:
> qcom,soft-start-us:
> @@ -46,7 +47,8 @@ properties:
>
> ibb:
> type: object
> - additionalProperties: false
> + $ref: "regulator.yaml#"

Drop quotes.

> + unevaluatedProperties: false
>
> properties:
> qcom,discharge-resistor-kohms:

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-26 23:43    [W:0.055 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site