Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 18 Jan 2023 03:24:34 +0200 | Subject | Re: [PATCH v2] drm/msm: Add missing check and destroy for alloc_ordered_workqueue | From | Dmitry Baryshkov <> |
| |
On 09/01/2023 04:20, Jiasheng Jiang wrote: > Add check for the return value of alloc_ordered_workqueue as it may return > NULL pointer. > Moreover, use the destroy_workqueue in the later fails in order to avoid > memory leak. > > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > Changelog: > > v1 -> v2: > > 1. Convert "goto err_destroy_workqueue" into "goto err_msm_unit" and > remove "err_destroy_workqueue" label. > --- > drivers/gpu/drm/msm/msm_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| ![\](/images/icornerr.gif) |