lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] arm64: dts: qcom: sc7280: add display port audio
Hi,

On Mon, Jan 16, 2023 at 6:42 PM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> 1. Add DisplayPort sound node and lpass_cpu node.
>
> 2. Adjust the dai-link order to make the order to
> be consistent with sc7280-herobrine-audio-rt5682-3mic.dtsi.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
>
> ---
>
> Changes in v3:
> - Add more detail in the commit message.
>
> Changes in v2:
> - Fix the commit message format.
>
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)

nit: Your ${SUBJECT} needs to make it obvious what this is changing. Like maybe:

arm64: dts: qcom: sc7280: add DP audio to herobrine rt5682 1-mic dtsi

Other than that this looks good to me:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

\
 
 \ /
  Last update: 2023-03-26 23:45    [W:0.024 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site