Messages in this thread | | | From | Pasha Tatashin <> | Date | Tue, 17 Jan 2023 15:04:46 -0500 | Subject | Re: [PATCH v3] mm/page_ext: Do not allocate space for page_ext->flags if not needed |
| |
Hey Mike,
> > Also, add a comment before page_ext_operations that describes the > > field, and remove check if need() is set, as that is now a required > > Nit: fields
OK
> > struct pglist_data; > > + > > +/* > > Please make it kerneldoc.
OK
> > void (*init)(void); > > + bool using_shared_ext_flags; > > I'd s/using_shared_ext_flags/need_shared_flags.
Sure
> > + * Note: that if none of the users of page_ext is setting > > I'd drop that ^that
OK
Thanks for the review, I will send a new version soon.
Pasha
| |