Messages in this thread | | | Date | Tue, 17 Jan 2023 13:27:24 -0600 | From | Rob Herring <> | Subject | Re: [PATCH 2/3] ASoC: dt-bindings: qcom,wcd934x: Describe slim-ifc-dev |
| |
On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote: > The "slim-ifc-dev" property should not be just "true", because it allows > any type.
Yes, but it is common, so it should be in a common schema. Though there's only one other binding using it (wcd9335.txt).
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > index 184e8ccbdd13..39b27126cfc1 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > @@ -28,7 +28,9 @@ properties: > description: GPIO spec for reset line to use > maxItems: 1 > > - slim-ifc-dev: true > + slim-ifc-dev: > + description: IFC device interface > + $ref: /schemas/types.yaml#/definitions/phandle > > clocks: > maxItems: 1 > -- > 2.34.1 >
| |