lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rc] genirq/msi: Free the fwnode created by msi_create_device_irq_domain()
On Tue, Jan 17, 2023 at 07:42:39PM +0100, Thomas Gleixner wrote:
> Jason!
>
> On Tue, Jan 17 2023 at 11:27, Jason Gunthorpe wrote:
> > void msi_remove_device_irq_domain(struct device *dev, unsigned int domid)
> > {
> > + struct fwnode_handle *fwnode = NULL;
> > struct msi_domain_info *info;
> > struct irq_domain *domain;
> >
> > @@ -1025,7 +1026,10 @@ void msi_remove_device_irq_domain(struct device *dev, unsigned int domid)
> >
> > dev->msi.data->__domains[domid].domain = NULL;
> > info = domain->host_data;
> > + if (irq_domain_is_msi_device(domain))
> > + fwnode = domain->fwnode;
> > irq_domain_remove(domain);
> > + irq_domain_free_fwnode(fwnode);
>
> This can't work with !device domains because then fwnode is NULL and
> irq_domain_free_fwnode() will trip over its feet.

Uhh for some reason I thought I checked that. I'll send a v2

Thanks,
Jason

\
 
 \ /
  Last update: 2023-03-26 23:44    [W:0.028 / U:2.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site