Messages in this thread | | | From | Bjørn Mork <> | Subject | Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops | Date | Mon, 16 Jan 2023 17:45:12 +0100 |
| |
Bjørn Mork <bjorn@mork.no> writes:
>> You have bmcr=0x1000, but the code sets two bits - SGMII_AN_RESTART and >> SGMII_AN_ENABLE which are bits 9 and 12, so bmcr should be 0x1200, not >> 0x1000. Any ideas why? > > No, not really
Doh! Looked over it again, and this was my fault of course. Had an
"bmcr = SGMII_AN_ENABLE;"
line overwriting the original value from a previous attempt without changing the if condition.. Thanks for spotting that.
But this still doesn't work any better:
[ 43.019395] mtk_soc_eth 15100000.ethernet wan: Link is Down [ 45.099898] mtk_sgmii_select_pcs: id=1 [ 45.103653] mtk_pcs_config: interface=4 [ 45.107473] offset:0 0x140 [ 45.107476] offset:4 0x4d544950 [ 45.110181] offset:8 0x20 [ 45.113305] forcing AN [ 45.118256] mtk_pcs_config: rgc3=0x0, advertise=0x1 (changed), link_timer=1600000, sgm_mode=0x103, bmcr=0x1200, use_an=1 [ 45.129191] mtk_pcs_link_up: interface=4 [ 45.133100] offset:0 0x81140 [ 45.133102] offset:4 0x4d544950 [ 45.135967] offset:8 0x1 [ 45.139104] mtk_soc_eth 15100000.ethernet wan: Link is Up - 1Gbps/Full - flow control rx/tx
Bjørn
| |