Messages in this thread | | | Date | Mon, 16 Jan 2023 16:43:04 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/2] gpio: wcd934x: Use proper headers and drop OF_GPIO dependency |
| |
On Mon, Jan 16, 2023 at 02:56:23PM +0100, Bartosz Golaszewski wrote: > On Mon, Jan 16, 2023 at 1:00 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Jan 16, 2023 at 10:03:47AM +0100, Bartosz Golaszewski wrote: > > > On Fri, Jan 13, 2023 at 7:25 PM Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote:
...
> > > > +#include <linux/mod_devicetable.h> > > > > #include <linux/module.h> > > > > -#include <linux/gpio/driver.h> > > > > +#include <linux/platform_device.h> > > > > #include <linux/regmap.h> > > > > #include <linux/slab.h> > > > > -#include <linux/of_device.h> > > > > + > > > > +#include <linux/gpio/driver.h> > > > > > > Any reason for having it separately here? > > > > Yes. The idea is to emphasize the relationship between the driver and > > the subsystem it's written for.
> We almost never do it and I prefer all linux/ headers to be grouped > together. I like separate sections for asm/ and local includes but > this is overkill IMO.
OK!
-- With Best Regards, Andy Shevchenko
| |