lkml.org 
[lkml]   [2023]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()
On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote:
> <yang.yang29@zte.com.cn> wrote:
>
> > From: Xu Panda <xu.panda@zte.com.cn>
> >
> > The implementation of strscpy() is more robust and safer.
> > That's now the recommended way to copy NUL-terminated strings.
> >
> > Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> > Signed-off-by: Yang Yang <yang.yang29@zte.com>
>
> Mismatch email in From and Signed-off-by lines:
>
> From: <yang.yang29@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
>
> Patch set to Changes Requested.

Kalle, please be aware of this response
https://lore.kernel.org/netdev/20230113112817.623f58fa@kernel.org/

"I don't trust that you know what you're doing. So please don't send
any more strncpy() -> strscpy() conversions for networking."

Thanks

>
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/202212231037210142246@zte.com.cn/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

\
 
 \ /
  Last update: 2023-03-26 23:42    [W:0.043 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site