lkml.org 
[lkml]   [2023]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 1/1] gpio: Remove unused and obsoleted irq_to_gpio()
From

On 13/1/23 01:14, Geert Uytterhoeven wrote:
> CC greg
>
> On Thu, Jan 12, 2023 at 2:39 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> irq_to_gpio() is legacy and unused API, remove it for good.
>>
>> This leaves gpio_to_irq() as it's used yet in many places.
>> Nevertheless, removal of its counterpart is a good signal
>> to whoever even trying to consider using them that do not.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> Documentation/driver-api/gpio/legacy.rst | 8 --------
>> .../translations/zh_CN/driver-api/gpio/legacy.rst | 7 -------
>> Documentation/translations/zh_TW/gpio.txt | 7 -------
>> arch/m68k/include/asm/gpio.h | 7 -------
>> arch/sh/include/asm/gpio.h | 5 -----
>> include/linux/gpio.h | 12 ------------
>> 6 files changed, 46 deletions(-)
>
> [...]
>
>> --- a/arch/m68k/include/asm/gpio.h
>> +++ b/arch/m68k/include/asm/gpio.h
>> @@ -66,13 +66,6 @@ static inline int gpio_to_irq(unsigned gpio)
>> return __gpio_to_irq(gpio);
>> }
>>
>> -static inline int irq_to_gpio(unsigned irq)
>> -{
>> - return (irq >= MCFGPIO_IRQ_VECBASE &&
>> - irq < (MCFGPIO_IRQ_VECBASE + MCFGPIO_IRQ_MAX)) ?
>> - irq - MCFGPIO_IRQ_VECBASE : -ENXIO;
>> -}
>> -
>> static inline int gpio_cansleep(unsigned gpio)
>> {
>> return gpio < MCFGPIO_PIN_MAX ? 0 : __gpio_cansleep(gpio);
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Greg Ungerer <gerg@linux-m68k.org>



> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

\
 
 \ /
  Last update: 2023-03-26 23:42    [W:0.080 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site