Messages in this thread | ![/](/images/icornerl.gif) | | From | Bartosz Golaszewski <> | Date | Mon, 16 Jan 2023 10:03:19 +0100 | Subject | Re: [PATCH v2 1/2] gpio: wcd934x: Remove duplicate assignment of of_gpio_n_cells |
| |
On Fri, Jan 13, 2023 at 7:25 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The of_gpio_n_cells default is 2 when ->of_xlate() callback is > not defined. No need to assign it explicitly in the driver. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v2: no changes > drivers/gpio/gpio-wcd934x.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c > index 97e6caedf1f3..817750e4e033 100644 > --- a/drivers/gpio/gpio-wcd934x.c > +++ b/drivers/gpio/gpio-wcd934x.c > @@ -98,7 +98,6 @@ static int wcd_gpio_probe(struct platform_device *pdev) > chip->base = -1; > chip->ngpio = WCD934X_NPINS; > chip->label = dev_name(dev); > - chip->of_gpio_n_cells = 2; > chip->can_sleep = false; > > return devm_gpiochip_add_data(dev, chip, data); > -- > 2.39.0 >
Applied, thanks!
Bart
| ![\](/images/icornerr.gif) |