Messages in this thread | ![/](/images/icornerl.gif) | | From | Bartosz Golaszewski <> | Date | Mon, 16 Jan 2023 10:00:45 +0100 | Subject | Re: [PATCH v1 1/2] gpio: zevio: Remove duplicate assignment of of_gpio_n_cells |
| |
On Thu, Jan 12, 2023 at 5:39 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The of_gpio_n_cells default is 2 when ->of_xlate() callback is > not defined. No need to assign it explicitly in the driver. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-zevio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c > index ce9d1282165c..c9f4c26cae3d 100644 > --- a/drivers/gpio/gpio-zevio.c > +++ b/drivers/gpio/gpio-zevio.c > @@ -162,7 +162,6 @@ static const struct gpio_chip zevio_gpio_chip = { > .base = 0, > .owner = THIS_MODULE, > .ngpio = 32, > - .of_gpio_n_cells = 2, > }; > > /* Initialization */ > -- > 2.39.0 >
Applied, thanks!
Bart
| ![\](/images/icornerr.gif) |